Manager certificate permissions if manage_certificates true#599
Open
ehelms wants to merge 1 commit intotheforeman:masterfrom
Open
Manager certificate permissions if manage_certificates true#599ehelms wants to merge 1 commit intotheforeman:masterfrom
ehelms wants to merge 1 commit intotheforeman:masterfrom
Conversation
ehelms
force-pushed
the
cert-handling
branch
2 times, most recently
from
ad9caed to
b71baf8
Compare
ehelms
changed the title
ekohl
reviewed
Mar 19, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
We also have some code to manage Puppet certificates. I'm not entirely sure if this will conflict, but want you to be aware of it:
puppet-foreman_proxy/manifests/config.pp
Lines 114 to 135 in af23995
ehelms
force-pushed
the
cert-handling
branch
3 times, most recently
from
50b00c6 to
3dc3c6d
Compare
Member
Author
|
I'm stuck on why the tests are not seeing the resource present. |
Contributor
Use |
alexjfisher
reviewed
Mar 24, 2025
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving an old PR with fresh updates. The idea behind this is at the users choice, the module can manage the certificates for the smart-proxy. When true, this will copy certificates provided into a known and controlled location, ensuring the right owner and group are set on them such that the smart-proxy can operate as intended. This is borrowed from, and can replace, puppet-certs implementation and help prevent an ordering problem with certificate generation and deployment. And this can provide a native way to indicate when a service restart is needed.